JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

Refactored function names in R/fa2domain.R #59

Closed teddyCodex closed 1 month ago

teddyCodex commented 1 month ago

Description

Refactored functions in R/fa2domain.R based on #7

Original Modified User Facing
exec_interproscan runIPRScan
get_df_ipr_col_names getIPRScanColNames
get_df_ipr_col_types getIPRScanColTypes
read_iprscan_tsv readIPRScanTSV
make_df_iprscan_domains createIPRScanDomainTable
df_iprscan_domains2fasta convertIPRScanDomainTable2FA
fasta2fasta_domain getDomainsFromFA

Fixes issue #45

What kind of change(s) are included?

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

teddyCodex commented 1 month ago

@jananiravi @the-mayer File containing other occurrences of the functions. Please let me know if I should commit this file as well.

function_occurrences #45.txt

jananiravi commented 1 month ago

@teddyCodex, few minor fixes | also indicated in the original issue: runInterProScan --> runIPRScan getIPRScanColnames --> getIPRScanColNames getIPRScanColtypes --> getIPRScanColTypes

Could you double-check against my issue-specific notes + changes in the original issue #7?