Closed Seyi007 closed 3 weeks ago
Thanks for all your work on this @Seyi007. excellent points, @the-mayer! Looking forward to the changes!
Duly noted @the-mayer , I'll get to work on this!
Hi @the-mayer @jananiravi , I've implemented the suggestions made earlier and have updated the error handling in the R/acc2lin.R. Kindly review and let me know if I'm missing anything, while I work on the remaining functions.
Hi @jananiravi @falquaddoomi, I've implemented all the changes required from the previous review in my latest commit. Could you review this and let me know if I'm missing anything?
@falquaddoomi @the-mayer followed the conversation but not the most recent line-by-line edits. Feel free to merge if this looks good.
Thanks, @Seyi007 !
Yay! Thank you @falquaddoomi @jananiravi
Thanks for the additional work here, @Seyi007!
Finishing up with https://github.com/JRaviLab/MolEvolvR/pull/97 and will tackle merging this one next.
Implement error handling for mapOption2Process, get_proc_medians, write_proc_medians_table, get_proc_weights, advanced_opts2est_walltime, assign_job_queue, and plot_estimated_walltimes .
Validate input arguments for each function to ensure they meet expected criteria.
Use tryCatch blocks to handle errors and warnings gracefully.
Provide informative error messages and detailed logging where appropriate.
Ensure functions fail gracefully and provide useful feedback.
[x] Feature (adds or updates new capabilities)
[ ] Bug fix (fixes an issue).
[x] Enhancement (adds functionality).
[ ] Breaking change (these changes would cause existing functionality to not work as expected).
Checklist