JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

Added error handling to multiple functions in R/assign_job_queue.R, R/blastWrappers.R #76

Closed Seyi007 closed 3 weeks ago

Seyi007 commented 1 month ago

Checklist

jananiravi commented 1 month ago

Thanks for all your work on this @Seyi007. excellent points, @the-mayer! Looking forward to the changes!

Seyi007 commented 1 month ago

Duly noted @the-mayer , I'll get to work on this!

Seyi007 commented 1 month ago

Hi @the-mayer @jananiravi , I've implemented the suggestions made earlier and have updated the error handling in the R/acc2lin.R. Kindly review and let me know if I'm missing anything, while I work on the remaining functions.

Seyi007 commented 1 month ago

Hi @jananiravi @falquaddoomi, I've implemented all the changes required from the previous review in my latest commit. Could you review this and let me know if I'm missing anything?

jananiravi commented 1 month ago

@falquaddoomi @the-mayer followed the conversation but not the most recent line-by-line edits. Feel free to merge if this looks good.

Thanks, @Seyi007 !

Seyi007 commented 1 month ago

Yay! Thank you @falquaddoomi @jananiravi

the-mayer commented 3 weeks ago

Thanks for the additional work here, @Seyi007!

Finishing up with https://github.com/JRaviLab/MolEvolvR/pull/97 and will tackle merging this one next.