search

JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

Refactor internal functions to be defined outside of plot functions #80

Closed the-mayer closed 3 weeks ago

the-mayer commented 1 month ago 
          Tagging functions for future review.

The following internal functions should be defined outside of the plotting functions that currently use them. This way, the plot functions can reference these external functions, avoiding the need to define functions within functions.

Originally posted by @the-mayer in https://github.com/JRaviLab/MolEvolvR/issues/63#issuecomment-2400073453

teddyCodex commented 1 month ago

taking a crack at this @the-mayer

Joiejoie1 commented 1 month ago

@teddyCodex are you working on this or can I give it a shot as well?

teddyCodex commented 1 month ago

Hi @Joiejoie1 Already raised a PR Waiting on @the-mayer to review.