JRaviLab / MolEvolvR

An R Package for characterizing proteins using molecular evolution and phylogeny
https://jravilab.github.io/MolEvolvR/
Other
6 stars 16 forks source link

Refactor: Externalize .LevelReduction and .GetKingdom for global use #85

Closed teddyCodex closed 3 weeks ago

teddyCodex commented 1 month ago

Description

Defines .LevelReduction and .GetKingdom outside of the plotLineageHeatmap function, eliminating the need for functions within a function and making them globally accessible.

devtools::check() - 0 errors

Fixes issue #80

What kind of change(s) are included?

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

the-mayer commented 3 weeks ago

Thanks @teddyCodex, just added a quick comment to verify that we aren't breaking the plot code. Note, I've also invited @Joiejoie1 to provide a review as they have also been working on this issue. Thanks both!

Joiejoie1 commented 3 weeks ago

Thanks @teddyCodex, just added a quick comment to verify that we aren't breaking the plot code. Note, I've also invited @Joiejoie1 to provide a review as they have also been working on this issue. Thanks both!

Thamks @the-mayer I'll do just that

jananiravi commented 3 weeks ago

Good work, @teddyCodex @Joiejoie1! thanks for the PR!