Doesn't work with mdx-deck v2

JReinhold commented 5 years ago

The current iteration of mdx-deck-live-code was made for mdx-deck@1.x, and doesn't seem to work with mdx-deck@2.x. Another unfortunate consequence of this, is that it doesn't work with the CodeSandbox mdx-deck template.

The main reason it doesn't work, is the fact that mdx-deck switched from styled-components to emotion in version 2. There may be other reasons it doesn't work, but at the moment that is the only one I know of.

To fix this, a (non exhaustive) todo list could look like:

[ ] Migrate from styled-components to emotion
[ ] Bump mdx-deck-live-code to v2, as this is probably a breaking change
[ ] Note in the README.md which versions support which versions of mdx-deck
[ ] Migrate to react-live@2.x as well, unless it is so big a change that it needs it's own PR.

Everyone is welcomed to give this a go.

uyarn commented 4 years ago

would like to implement it

JReinhold commented 4 years ago

would like to implement it

Awesome, go ahead! Let me know if you need any pointers beyond the initial todo list.

JReinhold / mdx-deck-live-code

Doesn't work with mdx-deck v2 #12