Closed forevermatt closed 6 months ago
I like this idea! I think what might be happening here is that dry-run
doesn't affect the version check logic, so if you're in dry-run mode but the version in question is already released, npm publish --dry-run
will never be called.
What we could do is have dry-run
proceed past the version check (with appropriate logging) and run npm publish --dry-run
no matter what. I think if we do that, we'll get the nice little pack log
Sounds promising, thanks! Unfortunately, I'm not familiar enough with this codebase to submit a PR myself. Sorry. π
All good! Itβll be a pretty small lift if my assumptions hold π€, will take a crack at it by Friday
Awesome, thanks! We're already seeing those changes in our builds, and it looks great! π π
Have you considered including more of the standard output of npm's "dry run" mode? I find that quite helpful sometimes, such as to see what all files would be included in the published package (so that I can adjust things to remove unneeded files).
Here's a slightly-redacted example of what npm shows:
However, the npm-publish GitHub action seems to only show something like this:
Thank for making helpful open source packages, nonetheless! π