JSAbrahams / mamba

🐍 The Mamba programming language, because we care about safety
MIT License
88 stars 4 forks source link

Add grcov and codecov, clippy #231

Closed JSAbrahams closed 2 years ago

JSAbrahams commented 2 years ago

Also add clippy warnings to a pull request. Ideally, pull requests should not be merged which have formatting issues either.

Tooling has up until this point been somewhat neglected. We want to for now be up to date on the coverage, and ideally only merge pull requests which do not, or only marginally, decrease coverage. The latter should be strongly motivated. However, seeing as we're writing a transpiler, I'd argue that it is certainly possible to test a very large portion of the codebase.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6c67a1e). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #231   +/-   ##
==========================================
  Coverage           ?   75.66%           
==========================================
  Files              ?       99           
  Lines              ?     6748           
  Branches           ?        0           
==========================================
  Hits               ?     5106           
  Misses             ?     1642           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c67a1e...d92e9da. Read the comment docs.

JSAbrahams commented 2 years ago

Some small fill formatting changes such that rustfmt should not complain

JSAbrahams commented 2 years ago

Should note that the clippy action catches a lot more than when I run it locally. Not quite sure what's happening there.