JSAbrahams / mamba

🐍 The Mamba programming language, because we care about safety
MIT License
88 stars 4 forks source link

Generalize Collection Type Lookup #281

Closed JSAbrahams closed 2 years ago

JSAbrahams commented 2 years ago

Summary

Generalize how one looks at a type:

This solution means that the collection lookup generalizes to all types which define an iterator. For instance, we can now also index Strings, which also have an iterator.

Also final round of tests before the next release. Shouldn't be too much since we typically test as features are implemented, but looking at it with a fresh perspective can't hurt though.

Added Tests

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@9dd3502). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #281   +/-   ##
==========================================
  Coverage           ?   85.43%           
==========================================
  Files              ?       99           
  Lines              ?     9811           
  Branches           ?        0           
==========================================
  Hits               ?     8382           
  Misses             ?     1429           
  Partials           ?        0           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

JSAbrahams commented 2 years ago

Well, if we're so close to 84% coverage, maybe sneak in a few extra tests here.

JSAbrahams commented 2 years ago

Re-added all ignored tests which previously failed, quite a lot of bugs and/or missing language features which had been solved in the meantime.