JSAbrahams / mamba

🐍 The Mamba programming language, because we care about safety

MIT License

88 stars 4 forks source link

Use write! not format! in delimit functions #286

Closed JSAbrahams closed 2 years ago

JSAbrahams commented 2 years ago

Summary

This PR does two things:

1

Clippy mentioned that it is better to use write! if we keep appending to a string directly to prevent extra allocation. Won't matter much in the grand scheme of things, but better practice.

Some extra changes as well because we format whatever file we touch.

2

Remove the pipeline dir and make io top-level. The pipeline functionality, which should be part of the interface, is part of the library (lib) now.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f250137). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #286   +/-   ##
==========================================
  Coverage           ?   85.45%           
==========================================
  Files              ?       98           
  Lines              ?     9841           
  Branches           ?        0           
==========================================
  Hits               ?     8410           
  Misses             ?     1431           
  Partials           ?        0

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more