JSAbrahams / mamba

🐍 The Mamba programming language, because we care about safety
MIT License
85 stars 3 forks source link

Add optional to Name in generate #310

Closed JSAbrahams closed 2 years ago

JSAbrahams commented 2 years ago

Relevant issues

Summary

Always print out generics in alphabetical order. This ensures that the output is easy to predict, we are not dependent on the whims of the iterator over the set, possibly preventing flaky tests.

Make annotating output the default in tests as well. As we start to implement new features and debug the checking stage we should then automatically see old tests failing as well.

Should create issues for all unexpected/wrong behavior before merging this PR. At the very least we can now more clearly see what the checker is doing on the hood, which is great!

Added Tests

JSAbrahams commented 2 years ago

Only unmark as draft after having created issues for all unexpected behaviour. This is so they aren't forgotten.

codecov[bot] commented 2 years ago

Codecov Report

Merging #310 (353a81b) into develop (a4a9f1d) will increase coverage by 0.41%. The diff coverage is 99.07%.

@@             Coverage Diff             @@
##           develop     #310      +/-   ##
===========================================
+ Coverage    86.30%   86.71%   +0.41%     
===========================================
  Files          105      105              
  Lines        10825    10928     +103     
===========================================
+ Hits          9342     9476     +134     
+ Misses        1483     1452      -31     
Impacted Files Coverage Δ
src/generate/name.rs 98.48% <99.07%> (+98.48%) :arrow_up:
src/check/context/clss/mod.rs 77.06% <0.00%> (-2.76%) :arrow_down:
src/lib.rs 85.23% <0.00%> (+0.51%) :arrow_up:
src/generate/convert/definition.rs 90.26% <0.00%> (+0.74%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

JSAbrahams commented 2 years ago

Actually, I can just go through the codebase and create issues. No need to postpone merging this PR.