JSAbrahams / mamba

🐍 The Mamba programming language, because we care about safety
MIT License
85 stars 3 forks source link

Improve context from python src #313

Closed JSAbrahams closed 2 years ago

JSAbrahams commented 2 years ago

Relevant issues

Flagged some issues when generating Context from Python source:

Summary

A lot of the behaviour of the context has assumed to been correct. However, as we implement more advanced features, verifying the behaviour of the Context will save us some time. For instance, inferring expected behaviour from Python primitives and standard library from the built-in resources.

It might also help in future if we ever decide to do a major refactor. For instance, we may need to update our dependencies if it cannot parse properly the newest Python constructs.

Added Tests

codecov[bot] commented 2 years ago

Codecov Report

Merging #313 (7f9025d) into develop (a4a9f1d) will increase coverage by 0.82%. The diff coverage is 91.37%.

@@             Coverage Diff             @@
##           develop     #313      +/-   ##
===========================================
+ Coverage    86.30%   87.12%   +0.82%     
===========================================
  Files          105      105              
  Lines        10825    11313     +488     
===========================================
+ Hits          9342     9856     +514     
+ Misses        1483     1457      -26     
Impacted Files Coverage Δ
src/check/context/arg/python.rs 100.00% <ø> (ø)
src/check/context/parameter/generic.rs 0.00% <ø> (ø)
src/check/context/parameter/python.rs 57.69% <ø> (ø)
src/check/context/parent/generic.rs 78.57% <ø> (-2.68%) :arrow_down:
src/check/context/python.rs 71.05% <0.00%> (ø)
src/check/name/truename/generic.rs 62.96% <50.00%> (ø)
src/check/context/field/python.rs 48.78% <58.82%> (+10.94%) :arrow_up:
src/check/context/clss/python.rs 86.82% <83.84%> (-2.97%) :arrow_down:
src/check/context/function/generic.rs 92.07% <91.11%> (+3.36%) :arrow_up:
src/check/context/function/python.rs 96.87% <94.73%> (-3.13%) :arrow_down:
... and 21 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more