JSAbrahams / mamba

🐍 The Mamba programming language, because we care about safety

MIT License

88 stars 4 forks source link

Context restructure #341

Closed JSAbrahams closed 2 years ago

JSAbrahams commented 2 years ago

Relevant issues

Closes #321
Made note of #343

Summary

Generalize how class lookup work in Context

No major bugs have really been fixed. However, we have restructured the Context so we don't have to deal with a lot of edge cases and instead use a more generalized system.

Added Tests

Print Tuple and Callable.
Some checks that HasParent has been properly implemented for some primitives.

codecov[bot] commented 2 years ago

Codecov Report

Merging #341 (98c8951) into develop (f4d068d) will decrease coverage by 0.56%. The diff coverage is 61.22%.

@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
- Coverage    86.95%   86.38%   -0.57%     
===========================================
  Files          104      109       +5     
  Lines        11374    11647     +273     
===========================================
+ Hits          9890    10061     +171     
- Misses        1484     1586     +102

JSAbrahams commented 2 years ago

The drop in coverage is somewhat significant. A lot of logic has been moved around or added. A lot of it is not really that necessary to test though, since a lot of logic is about the order of names. This is mostly so that the ordering is consistent for cases where we need to e.g. order sets in a deterministic manner.