search

JSBSim-Team / jsbsim

An open source flight dynamics & control software library
GNU Lesser General Public License v2.1
1.22k stars 420 forks source link

upgrade working for 5.1 #1051

Open tsky1971 opened 1 month ago

tsky1971 commented 1 month ago

fix iwyu (https://docs.unrealengine.com/5.0/en-US/include-what-you-use-iwyu-for-unreal-engine-programming/) fix/add missing category for blueprint (needs for 5.1) compile with 5.1 add build batch (buildpath is more temp - long name of the plugin leads easy to max path length >254)

gallonmate commented 1 month ago

Thanks for adding improvements/changes. The plugin is currently compatible with all versions UE5.0 to 5.3, using Windows and Visual Studio. I'm adding comments/reviews to remove references to UE5.1, which break compatibility with UE5.0.

Also it would be good to update the Unreal plugin Readme so that people are aware of the buildplugin.bat and how to use it.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.97%. Comparing base (3c7582e) to head (b9a3eeb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1051 +/- ## ======================================= Coverage 24.97% 24.97% ======================================= Files 168 168 Lines 18057 18057 ======================================= Hits 4510 4510 Misses 13547 13547 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bcoconni commented 5 days ago

@gallonmate, @tsky1971 is this PR ready for merging ? Or are there still some pending issues ?

gallonmate commented 3 days ago

@gallonmate, @tsky1971 is this PR ready for merging ? Or are there still some pending issues ?

No this PR is not ready. I'm not even 100% sure this PR is necessary in the first place BUT I saw no harm as long as the author resolved the compatibility for all UE5 versions, which they did not address yet, (This PR breaks compatibility with UE5.0). If you don't hear anything from the author, feel free to close the PR.