Closed bcoconni closed 8 months ago
Merging #952 (424a47a) into master (e4aa2a9) will increase coverage by
0.01%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
+ Coverage 24.89% 24.90% +0.01%
==========================================
Files 168 168
Lines 18887 18890 +3
==========================================
+ Hits 4701 4704 +3
Misses 14186 14186
Files Changed | Coverage Δ | |
---|---|---|
src/FGFDMExec.cpp | 39.16% <0.00%> (ø) |
|
src/initialization/FGInitialCondition.cpp | 45.33% <0.00%> (ø) |
|
src/initialization/FGInitialCondition.h | 74.71% <ø> (ø) |
|
src/math/FGParameterValue.h | 100.00% <ø> (ø) |
|
src/models/FGInertial.cpp | 62.12% <0.00%> (ø) |
|
src/models/FGInertial.h | 78.57% <ø> (ø) |
|
src/input_output/FGPropertyManager.cpp | 52.89% <100.00%> (ø) |
|
src/input_output/FGPropertyManager.h | 86.20% <100.00%> (-1.07%) |
:arrow_down: |
All looks good to me.
Good !
I've also added some further changes to the unit tests:
GetGamma()
has been removed from the class DummyAtmosphere
in the test FGAtmosphereTest
as it was a duplication of FGAtmosphere::SHRatio
.FGauxiliaryTest
now calls FGPropertyManager::Unbind()
to avoid having messages about properties already being tied.
FGAuxiliaryTest
has also been renamed FGAuxiliaryTest
instead of FGAtmosphereTest
(the code was obviously copied from FGAtmosphereTest
😉).
This PR brings a number of minor changes:
README.md
.FGInitialCondition::Load()
is renamed fromuseStoredPath
touseAircraftPath
which, I think, is more explicit.FGPropertyManager::Unbind()
that takes astd::shared_ptr
argument. This avoids explicitly calling the methodstd::shared_ptr::get()
when usingUnbind()
i.e. this is syntactic sugar :smiley:FindDifferences
inJSBSim_utils.py
as theDataFrames.lookup
method is now obsolete in the librarypandas
2.0.getOutput
has been increased from 0.5s to 1.0s in the test caseTestInputSocket.py
. This is to avoid this test to randomly fail with MSVC when our CI workflow is executed on GitHub.