JSC-electronics / Adeon

C++ library for processing commands from Adeon android mobile app.
Apache License 2.0
0 stars 0 forks source link

Adeon crashes when setting parameter name longer than 16 characters #12

Closed vzahradnik closed 3 years ago

vzahradnik commented 3 years ago

When user tries to set up a parameter longer than 16 characters (maximum supported length), and also he wants to set a callback, Adeon code is accessing unallocated object.

  1. First, Adeon tries to store the parameter in the list
  2. Then it compares the parameter length, and because it exceeds maximum supported length, it won't store the parameter
  3. The function returns NULL reference
  4. Adeon doesn't check the NULL reference, and stores pointer to callback function
  5. Adeon crashes

This issue was fixed in #10

vzahradnik commented 3 years ago

Resolved in #10.