JSC-electronics / Adeon

C++ library for processing commands from Adeon android mobile app.
Apache License 2.0
0 stars 0 forks source link

SIMlib causes conflict with other Serial interfaces #8

Closed vzahradnik closed 3 years ago

vzahradnik commented 3 years ago

I gave Adeon SIMlib a reference to Serial1, and yet it was also affecting other device on Serial2. After I modified (and simplified) the code, everything worked fine.

Also, HardwareSerial and SoftwareSerial inherit from the Stream class. The code can be heavily simplified.

vzahradnik commented 3 years ago

It should be resolved in #4351607. However, please note that if the user uses GSM::GSM(...) constructor other than the one which requires Stream pointer, the Adeon code can still clash with other libraries.

Adeon uses Serial2 on ESP32 and Arduino Mega.

In all cases, where fine control is required, users should pass a reference to the Stream object.