Well i guess there can be a toggle in the respawn to spawn

JSH32 / DiscordLink

Minecraft to Discord bridge

MIT License

14 stars 3 forks source link

Well i guess there can be a toggle in the respawn to spawn #7

Closed crazyaccess closed 3 years ago

JSH32 commented 3 years ago

Also the action java version is wrong so im not gonna run it run. Dont worry abt that

JSH32 commented 3 years ago

Also more descriptive names for PR and issues in the future please.

JSH32 commented 3 years ago

Java 11 btw

crazyaccess commented 3 years ago

Noice

JSH32 commented 3 years ago

Yeah fix the naming and the error i put in review and ill merge.

JSH32 commented 3 years ago

Added two new reviews.

crazyaccess commented 3 years ago

2 new reviews ?

JSH32 commented 3 years ago

Comments. Read the things I just left

crazyaccess commented 3 years ago

Oke i will have more descriptive stuff in the future

JSH32 commented 3 years ago

Nono i mean the code review comments.

JSH32 commented 3 years ago

Where it says riku started review

crazyaccess commented 3 years ago

I will test the artifact produced rn...

crazyaccess commented 3 years ago

checked it myself with all the permutations and combinations (well there were just 4 combinations tho)

crazyaccess commented 3 years ago

If you by chance merge this one, pls keep it open i will add more enhancement to this one like if the bed / spawn point (those nether spawn pillars) exist then they can optionally have a flag in the config on teleporting there instead of the world spawn or have a completely different teleport local altogether

JSH32 commented 3 years ago

If you do that make another PR and make it required. Respawn point is ideal