JSI-ETH / Mobile-NPC

MIT License
0 stars 3 forks source link

New product doesn't appear in mobile scan #6

Open joshzamor opened 3 years ago

joshzamor commented 3 years ago

Summary

(As a user of the NPC mobile application, I am unable to view a registered product in the PCMT in the application's product list. I am supposed to view the registered product

through the mobile application when I scan a barcode for any given commodity. The application should return summary details of the product upon scanning)

Steps to reproduce

Creating the Product in PCMT

  1. Navigate to the PCMT URL

  2. Login as an administrator

  3. Click on "products" in the navigation pane

  4. Click on "Create" in the main window

  5. Click on "Product"

  6. Enter the "Unique ID" and "Family Name" for the product.

  7. In the new product window that opens, fill in all required attribute information for the product and click on "Save Draft".

  8. Click on "Activity" in the left pane

  9. Click on "Drafts" and search for the newly created product by ID or navigating the table until you locate the item.

  10. Under the "Actions" column, click on the "Approve Draft" to publish the product for public view

Scanning the Product via the NPC Mobile Application

  1. Open the NPC application on your mobile device

  2. Click on the "SCAN" tab to scan the recently created product in the "PCMT".

  3. Scan your product

  4. The application will return summary details about the product

Viewing the Newly Created Product in the NPC Mobile Application

  1. Open the NPC application on your mobile device

  2. Under the "Browse Products" tab, search for the newly created product by ID

What is the current bug behavior?

The NPC mobile application is unable to pull information for the newly created product in PCMT upon scanning the product.

The NPC mobile application is unable to return the product upon searching for it by ID

What is the expected correct behavior?

The NPC mobile application should be able to pull information for the newly created product in PCMT upon scanning the product.

The NPC mobile application should be able to return the product upon searching for it by ID

Relevant logs and/or screenshots

Error message

Sorry!

The item with the specified GTIN 0118901213006973104120Z029 

1721062721H594JMN06GMNGNN1 could not be found. Please try again!

Barcode Scanned

18901213006973_COVISHIELD

18901213006973_COVISHIELD-barcode

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

joshzamor commented 3 years ago

This is forwarded on behalf of Kondwani. Following up to see if this has to do with a category setting expectation.

joshzamor commented 3 years ago

This has been double-checked with the category setting on the PCMT side, and confirmed that even after the category is set, the product doesn't scan/appear in the mobile app. I recommend the Bug label is added to this one.

joshzamor commented 3 years ago

on-deck for week of 4/19

joshzamor commented 3 years ago

note from call:

joshzamor commented 3 years ago

Hi @eyassug , that library I have in my notes is I think this one: https://github.com/gs1/interpretGS1scan . It is from GS1, under Apache 2.0, and in JS not Java.

Edit: to note I haven't used this library myself yet, only have it in my notes for reference from past research.

eyassug commented 3 years ago

Hi @joshzamor , I found a c# library https://github.com/ilopez/GS1Parser . This should fix the issue

eyassug commented 3 years ago

@joshzamor I have added a fix for this issue and pushed to develop. please let me know if the issue persists