search

JSJitsu / ai-battle-engine

Engine for powering the game logic.
https://jsfight.club
9 stars 8 forks source link

Convert the project code to use ES6 standards #11

Closed Asuza closed 7 years ago

Asuza commented 7 years ago

The battle engine was written a few years ago and could use some updating. Rather than using prototypes, update the engine to use classes instead. Remove var statements in favor of let or const, and use arrow functions (where it makes sense to) in place of standard functions.

adityaparab commented 7 years ago

Cool... Got here from hactoberfest github filter. I'd love to work on this.

Asuza commented 7 years ago

It's all yours, @adityaparab.

romainlq commented 7 years ago

Looks like I missed the train ! Shouldn't you guys make the PR starting from October 1st ? I mean, if you're here for Hacktoberfest..

Asuza commented 7 years ago

@wildan3105, I appreciate your eagerness to get a PR ready to go, but I'm going to have to give @adityaparab a chance to submit a PR to be merged as well. If you do want to work on a different issue, please claim it via a comment so others don't unintentionally spend time on fixing something that may not end up getting merged.

You're probably right, @romainwn, though I can't blame anyone for wanting to get started as early as possible. I'll be creating more issues as soon as I have time in this and the other @JSJitsu repos, if you're interested. I always try to explain each issue in detail and make the issues relatively straightforward and self-contained.

wildan3105 commented 7 years ago

got that :ok:

Asuza commented 7 years ago

Closed via #17. Thanks, @adityaparab!