Closed himanshujariyal closed 6 years ago
@himanshujariyal, thank you for your update. It's looking very nice. There are some merge conflicts due to another issue being merged, but changes will hopefully be minor. Feel free to update any var
to let
after you merge in the latest master changes.
If it's too much effort to include the "SP" value for any team member to spawn to, I can remove that part of the ticket and make that a separate issue. Just let me know.
@himanshujariyal, how's this going?
@Asuza Sorry for the delay, got a bit busy, I'll pick this up this weekend.
This feature was added via #26.
Purpose
Basic draft for adding custom spawn points in game. #12
Created an early PR so that you can check the implementation logic and code organization part, once that is done I can start writing test cases.
Description of changes
Validating Map: While calculating the number of games required, we use a variable
maxUsersPerTeam
, same variable is used to validate a randomly chosen map. (Example: IfmaxUsersPerTeam
is 4, in this case number of spawn points should be at least 4 for each team or 0 overall), if a map doesn't satisfy these conditions we will randomly choose another map till we have the required number of maps.Adding Hero: If map has spawn points then we can add hero only in spawn locations defined for hero's team, If there are no spawn points in map, we can add hero in any Unoccupied space.
Unoccupied: has now a new
subType
:SpawnPoint
andspawnValue
:S1
orS2
cc: @Asuza