Installed eslint, added eslint rules and lint script with --fix flag

JSJitsu / ai-battle-engine

Engine for powering the game logic.

https://jsfight.club

9 stars 8 forks source link

Installed eslint, added eslint rules and lint script with --fix flag #7

Closed dmnkgrc closed 7 years ago

dmnkgrc commented 7 years ago

Should fix #5 :)

simeg commented 7 years ago

Woah, 3425 files changed. You should split up your changes into multiple commits so it's easier to review this PR :)

Asuza commented 7 years ago

@dmnkgrc, thanks for the PR! I probably should have been more specific in mentioning to not check in the _nodemodules directory. I already have .gitignore files in other repos to ignore it and didn't think about it.

Would you please update the PR to not include the _nodemodules folder? In case I didn't mention it earlier, eslint should be able to be installed by running npm install.

dmnkgrc commented 7 years ago

Sorry, didn't realize there wasn't a .gitignore

Asuza commented 7 years ago

@dmnkgrc, this PR is looking really good. If you can make the two adjustments I mentioned above, and fix the merge conflict, I believe it will be ready to merge. Thanks!

dmnkgrc commented 7 years ago

Done :)

Asuza commented 7 years ago

Thanks, @dmnkgrc!