JSONPath-Plus / JSONPath

A fork of JSONPath from http://goessner.net/articles/JsonPath/
Other
958 stars 169 forks source link

Feature/add basic cli #206

Closed vid closed 5 months ago

vid commented 5 months ago

PR description

Adds a basic command line interface. No tests are provided since it just invokes the tested lib and we aren't here to test the runtime.

Checklist

vid commented 5 months ago

Hi, makes sense. I think it's better not to have two bin options so went with the original package name, but happy to make further improvements. Thanks!

brettz9 commented 5 months ago

I'm thinking maybe we should add a jsonpath-plus binary too so that people can use the package name (as you originally did in the docs), as well as the shorter jsonpath.

vid commented 5 months ago

Oh you're right, I just added the package name as a bin mapping.

brettz9 commented 5 months ago

I changed to avoid a dist file (I think CLI users can generally use the latest version) and linted the file. If you want to take a look, I think it should be ready after that.

vid commented 5 months ago

Makes sense. For completeness (…) I added a files directive.

vid commented 5 months ago

Oh! I wasn't aware of that approach, reverted now.

brettz9 commented 5 months ago

So do the changes I added look ok?

vid commented 5 months ago

Yes, it all "lgtm." Thanks!

brettz9 commented 5 months ago

Thanks for the PR! Released as part of v8.1.0

vid commented 5 months ago

Thanks for guiding me through it.