search

JSONovich / jsonovich

A webextension for Firefox. Pretty-prints JSON content in the browser for easy, unobtrusive viewing.
https://addons.mozilla.org/firefox/addon/jsonovich/
Mozilla Public License 2.0
7 stars 3 forks source link

Firefox 4 (Gecko 2) support #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Install a Firefox 4 beta
2. Enable jsonovich (using the add-on compatability reporter add-on if 
necessary)
3. Attempt to view a json file

What is the expected output?
Neatly formatted json in the browser

What do you see instead?
Download dialog

What version of the product are you using? On what operating system?
jsonovich 1.5.1, ff 4 (b5, b6), win 7 x64

Please provide any additional information below.
The code at the bottom of 
http://code.google.com/p/jsonview/source/browse/trunk/src/components/jsonview.js
 might be useful since that add-on does work in ff4 beta (but I prefer 
jsonovich), I don't know anything about XPCOM though...

Original issue reported on code.google.com by W.Elwoo...@gmail.com on 17 Sep 2010 at 11:00

GoogleCodeExporter commented 9 years ago 
Thanks, W.Elwood08.  I'd like to support fx4; the changes necessary look 
somewhat significant, so I'll need to do some reading before I can hack on 
this.  It seems the XPCOM stuff is simpler in fx4, and may replace all or most 
of what's in events.js.

I have a baby coming very soon; the likelihood of finding time to work on this 
anytime soon is slim, unfortunately!  If you do decide to delve into the XPCOM 
stuff, I am always accepting patches.  Or even better, I'd be happy to give you 
direct commit access to this project.  Ping me back here or in email if 
interested.

Original comment by michael.giarlo on 17 Sep 2010 at 3:28

GoogleCodeExporter commented 9 years ago 
So I got bored and played around with the code a bit... :p

Looked into the new sort of restart-less extension that ff4 supports but that 
seemed a little too complex to implement whilst maintaining backwards 
compatibility with ff3.

Then this morning I stumbled across the simplest solution and it works in my 
ff4 beta (but will need testing in ff3.x), so here it is. :)

There are a few other minor comment changes I made while I was researching the 
interfaces too, hopefully it's clear what I did to support ff4 though.

Original comment by W.Elwoo...@gmail.com on 19 Sep 2010 at 10:42

Attachments:

GoogleCodeExporter commented 9 years ago 
Finally got round to sorting test environments for Firefox 3.5 and 3.6, patch 
works as intended. :)

Original comment by W.Elwoo...@gmail.com on 1 Dec 2010 at 6:42