search

JSONovich / jsonovich

A webextension for Firefox. Pretty-prints JSON content in the browser for easy, unobtrusive viewing.
https://addons.mozilla.org/firefox/addon/jsonovich/
Mozilla Public License 2.0
7 stars 3 forks source link

Stop to work in Firefox 54.0 (64-bit) Ubuntu 16 #44

Closed danielbchaves closed 7 years ago

danielbchaves commented 7 years ago

I always used this addon and it suddenly stops to work, JSON's are just a plain text now.

I am using FF 54 and Ubuntu, tried to reinstall addon, getting version 1.99.4 from July 6, 2017, reopened browser but nothing changes.

Tried do chance settings in firefox (about:config) but the problem still happens with true or false devtools.jsonview.enabled = false

Tested in many services and here is a simple online test http://headers.jsontest.com/

hackel commented 7 years ago

Confirmed, running FF 56.0b3. I assume this is related to #43. Also, just to clarify, I'm referring to displaying JSON content in the browser itself, not in the developer tools.

Thanks for continuing this project @welwood08!

Edit: Here's the console output when loading some JSON, after enabling debugging. Didn't see anything useful, unfortunately.

18:32:53.887 [JSONovich Webext] onHeadersReceived Object { requestId: "9916", url: "http://headers.jsontest.com/", originUrl: "https://github.com/mjgiarlo/jsonovi…", documentUrl: undefined, method: "GET", tabId: 767, type: "main_frame", timeStamp: 1503099173884, frameId: 0, parentFrameId: -1, 4 more… } [{"name":"Access-Control-Allow-Origin","value":"*"},{"name":"Content-Type","value":"application/json; charset=ISO-8859-1"},{"name":"Content-Encoding","value":"gzip"},{"name":"X-Cloud-Trace-Context","value":"5081683b3e1344c26b37ccc922a1b007"},{"name":"Vary","value":"Accept-Encoding"},{"name":"Date","value":"Fri, 18 Aug 2017 23:32:53 GMT"},{"name":"Server","value":"Google Frontend"},{"name":"Cache-Control","value":"private"},{"name":"Content-Length","value":"320"}]  common.js:14:69
18:32:53.888 [JSONovich Webext] handleUrl "http://headers.jsontest.com/"  common.js:14:69
18:32:53.947 [JSONovich Webext] onCommitted Object { url: "http://headers.jsontest.com/", timeStamp: 1503099173928, frameId: 0, parentFrameId: -1, tabId: 767, windowId: 3, transitionType: "reload", transitionQualifiers: Array[0] } Array [  ] Array [  ]
welwood08 commented 7 years ago

For some reason my GitHub notifications were set not to email me for watched repos, so thanks for mentioning me directly - fixed that for future issues.

This is a duplicate of #39 that resurfaced in the new webext implementation (technically that test site is sending invalid JSON because the charset should always be UTF-8/16/32). I did fix it in source a day after submitting to AMO, but the AMO review unexpectedly took a month so I'd forgotten the fix needed to be pushed. Sorry about that, I'll try to squeeze a few more fixes in and push a new version to AMO some time this weekend.

welwood08 commented 7 years ago

1.99.5 approved.