search

JSRocksHQ / harmonic-theme-jsrocks

JSRocks Harmonic theme
5 stars 4 forks source link

CN categories link #27

Closed robsongajunior closed 9 years ago

robsongajunior commented 9 years ago

Categories link isn't supported in CN language. I'm looking for this.

UltCombo commented 9 years ago

Wait, it is just the CN categories that are linking to the English categories. This is weird, the pt-br categories work fine and they use the same template.

robsongajunior commented 9 years ago

it's easy to do a correction, i'm just checking if is pt-br else use default lang. One more case on switch case in the main.js archive

robsongajunior commented 9 years ago

i will take a look

UltCombo commented 9 years ago

@robsongajunior it would be nice if you could use a if/else testing if lang == config.i18n.default as in https://github.com/JSRocksHQ/harmonic-theme-jsrocks/blob/49f22ef25bfc5a2342fde505850d98502abb275e/partials/navigation.html#L5 This way you don't need case nor extra ifs.

robsongajunior commented 9 years ago

Flags ok, but categories not yet. It's so strange final result oO Me and @jaydson we will take a look tomorrow at morning.

status: not fixed yet

robsongajunior commented 9 years ago

fixed.

https://github.com/robsongajunior/harmonic-theme-jsrocks/commit/878e63401ad9d3719275164259afff4b8744cd89

robsongajunior commented 9 years ago

closed issue?

cc/ @UltCombo @jaydson

UltCombo commented 9 years ago

Yeah, nice work @robsongajunior :smile: