JSRocksHQ / harmonic

The next static site generator
http://harmonicjs.com/
MIT License
282 stars 26 forks source link

Add Node 0.10 compatibility, remove --harmony and v8-argv, update structure, bump deps #107

Closed UltCombo closed 9 years ago

UltCombo commented 9 years ago

Apart from adding Node 0.10 compatibility, this commit also includes:

NOTE: you may need to npm link again after pulling this commit.

Resolves #106

UltCombo commented 9 years ago

@jaydson please take a look.

jaydson commented 9 years ago

It didn't worked for me. after run npm link (the build worked well, passing all tests) i get this odd log: [23:27:55] Finished 'build' after 3.86 s /home/jaydson/.nvm/v0.11.14/bin/harmonic -> /home/jaydson/.nvm/v0.11.14/lib/node_modules/harmonic/entry_points/harmonic.js /home/jaydson/.nvm/v0.11.14/lib/node_modules/harmonic -> /home/jaydson/Workspace/harmonic jaydson@jaydson:~/Workspace/harmonic$

After that, running harmonic i get this error: /home/jaydson/.nvm/v0.11.14/bin/harmonic: line 1: use strict: command not found /home/jaydson/.nvm/v0.11.14/bin/harmonic: line 3: syntax error near unexpected token'./lib/polyfill'' /home/jaydson/.nvm/v0.11.14/bin/harmonic: line 3: require('./lib/polyfill');'

I'm missing something? I also tried to remove npm_modules and reinstall all dependencies. Node versions i tested: 0.10.36 and 0.11.14

UltCombo commented 9 years ago

@jaydson oops, I forgot the hashbang. Pull and try again. :D

jaydson commented 9 years ago

And now, it's working :+1:

UltCombo commented 9 years ago

yay :+1:

We need to update the Wiki sometime.

UltCombo commented 9 years ago

Updated the Wiki's Installing page: https://github.com/es6rocks/harmonic/wiki/Installing/_compare/8e0c0858ebf2412f46ec18922f464a24d3c7f0de...4316b3ac0888e1ab5e4e4bcfe98fe1e02359ee50