search

JSRocksHQ / harmonic

The next static site generator
http://harmonicjs.com/
MIT License
282 stars 26 forks source link

Removing JSHint and JSCS #109

Closed jaydson closed 9 years ago

jaydson commented 9 years ago

JSHint and JSCS was removed (for now). parser.js is now using template literals where possible. This PR closes #103

Revision needed //cc @UltCombo @leobalter @felipenmoura

jaydson commented 9 years ago

The watch task didn't break, but syntax errors was silent failing. So, i just put back the callback. I had removed before cause i thought the callback was something related to jscs.

UltCombo commented 9 years ago

Yes, I introduced that callback initially because gulp-jscs lacks reporters -- it currently throws errors instead of passing errors down the stream to a reporter, which will be changed in the near future. However, I also noticed that gulp-6to5 follows the same pattern as gulp-jscs, so we will need to keep that callback.

And nice work! I just won't be able to test it soon as I'm about to leave for an event.

UltCombo commented 9 years ago

I'm just not sure if we should be deleting those gulpfile and build.js lines instead of commenting them. Sure, "commented code doesn't belong in repositories", but if we're going to re-enable them in the future them it might be better to keep them commented out, otherwise having .jshintrc and gulp-jshint dependencies without any code using them looks a bit weird (although it is still possible to use the the global jshint CLI). Up to you. :D

jaydson commented 9 years ago

Yeah, i was thinking about it too. Let's keep the code commented, it's way easier to re-enable in the future.

UltCombo commented 9 years ago

:+1: