search

JSRocksHQ / harmonic

The next static site generator
http://harmonicjs.com/
MIT License
283 stars 26 forks source link

New logo #127

Closed UltCombo closed 9 years ago

UltCombo commented 9 years ago

See the new header here: https://github.com/es6rocks/harmonic/tree/new-logo

UltCombo commented 9 years ago

@jaydson does this look good for merging? I'm fixing some small details regarding linking atm.

UltCombo commented 9 years ago

I was trying to make the #harmonic fragment link to the README's title, it works now: https://github.com/es6rocks/harmonic/tree/new-logo#harmonic But GitHub is adding an extra paragraph above the heading due to the anchor and that results in too much margin-top.

UltCombo commented 9 years ago

I've removed the link which GitHub automatically adds to images from the logo (which was uselessly linking to the image source) by explicitly wrapping the logo with an anchor. In the future, the logo image could link to the Harmonic site (which is work in progress).

@jaydson think we can merge this? Is the logo size okay?

UltCombo commented 9 years ago

@italowaxman @jaydson can you guys take a look at the readme's new header? Is it too small or too big? (feel free to experiment changing the size through the DevTools) Any other suggestions/comments?

italowaxman commented 9 years ago

Its ok for me. Tell me something, can i make a header image to occupy 100% of the space?

jaydson commented 9 years ago

Seems perfect to me.

UltCombo commented 9 years ago

@italowaxman I think it is not really necessary -- the logo alone is good for branding. I don't know what you have in mind though, so feel free to experiment if you have too much spare time, but the Harmonic website should be a much higher priority at the moment.

italowaxman commented 9 years ago

No problem @UltCombo, then we will focus on the creation of harmonic website.