Closed jaydson closed 9 years ago
woah, this is looking very nice! I'll test it when I get home.
Found some small style nits, but I can fix them myself so don't worry. LGTM, excellent work @jaydson!
Now we can start adding true parallelism to the build, this should make the build even faster.
Attempt to fix #150
There's still some sync calls we need to remove:
readFileSync()
insrc/bin/theme.js
ThegetFileContents()
method is being called a lot of times in Harmonic class, and i can't find a way to make it async.readFileSync()
insrc/bin/helpers.js
We're callingreadFileSync
inhelpers.js
file, but consuming it on the constructor (see next).existsSync()
insrc/bin/parser.js
Kinda complicated because we're callingexistsSync()
method inside theconstructor
and we can't make aconstructor
async. I tried with an async IIFE inside theconstructor
and it not worked well. Also, the methodgetConfig()
is called inside the constructor.Travis says it's ok so far. https://travis-ci.org/JSRocksHQ/harmonic/builds/61412823
//cc @UltCombo