I18 pages - Githubissues

JSRocksHQ / harmonic

The next static site generator

http://harmonicjs.com/

MIT License

282 stars 26 forks source link

I18 pages #163

Closed viniciusdacal closed 9 years ago

viniciusdacal commented 9 years ago

fixed #73 Sorry about creating a new branch instead of using i18n_fix created by @jaydson , but I tried to use that and I got many conflict.

viniciusdacal commented 9 years ago

@UltCombo

UltCombo commented 9 years ago

The i18n_fix branch was not merged and diverged a lot (or rather, master diverged a lot from it), so it was actually better to create a new branch. I will review/test it soon. :smile:

UltCombo commented 9 years ago

Works great! Awesome job.

viniciusdacal commented 9 years ago

Thanks man :smile:

UltCombo commented 9 years ago

Two notes:

We should now be able to write the tests for harmonic new_page. It should be pretty similar to the new_post ones. Perhaps, in the future, we can even abstract it away so both of them use (most of) the same core logic.
The default harmonic theme's page template displays the page title twice in its body content. That one should be easy to fix.

I'm adding the "needs tests" label to remind that there's still a TODO regarding the pages.

viniciusdacal commented 9 years ago

tests added in #165

jaydson commented 9 years ago

Thanks for working on it @viniciusdacal !