Closed viniciusdacal closed 9 years ago
@UltCombo
The i18n_fix
branch was not merged and diverged a lot (or rather, master
diverged a lot from it), so it was actually better to create a new branch.
I will review/test it soon. :smile:
Works great! Awesome job.
Thanks man :smile:
Two notes:
harmonic new_page
. It should be pretty similar to the new_post
ones. Perhaps, in the future, we can even abstract it away so both of them use (most of) the same core logic.page
template displays the page title twice in its body content. That one should be easy to fix.I'm adding the "needs tests" label to remind that there's still a TODO regarding the pages.
tests added in #165
Thanks for working on it @viniciusdacal !
fixed #73 Sorry about creating a new branch instead of using
i18n_fix
created by @jaydson , but I tried to use that and I got many conflict.