search

JSRocksHQ / harmonic

The next static site generator
http://harmonicjs.com/
MIT License
282 stars 26 forks source link

Code style #39

Closed leobalter closed 10 years ago

leobalter commented 10 years ago

This PR addresses most of the code style catches from the new ES6Rocks code style.

And it also applies a npm test script to run JSHint and JSCS that can further use grunt or other automation tool to use their exact versions, as shown below:

jaydson commented 10 years ago

Hey @leobalter , Question: I didn't find jshint and jscs dependencies in package.json. Where we need to add those dependencies?

leobalter commented 10 years ago

Currently, it's using global installs of JSHint and JSCS, that's something I want to patch in a further PR, so we can discuss if we use grunt or keep it on NPM.

jaydson commented 10 years ago

I think npm is better, at least now. We should put JSHint and JSCS in package.json as dev-dependencies.

leobalter commented 10 years ago

done.

I miss the grunt watch.

leobalter commented 10 years ago

It's now rebased with master and ready to merge.