search

JSRocksHQ / harmonic

The next static site generator
http://harmonicjs.com/
MIT License
282 stars 26 forks source link

Fixing many minor issues #60

Closed UltCombo closed 9 years ago

UltCombo commented 9 years ago

PTAL.

Please review using the whitespace-insensitive flag: https://github.com/es6rocks/harmonic/pull/60/files?w=1

Fixes #54, #55, #56, #58. Work towards #53.

UltCombo commented 9 years ago

Yay Travis passed. =] I'm having issues to run npm test locally (#52), hence I was pushing to this PR so that Travis can run the tests for me.

UltCombo commented 9 years ago

Updated PR description and added comments.

I should probably have made separate PRs, but all of these changes are very tiny, ~90% of this PR are indentation level changes due to removing unnecessary promise wrapping.

Starting to look good to me, please review/test if you have time. I can take another look after I get up, before merging.

jaydson commented 9 years ago

Terrific job @UltCombo ! I've tested locally, and everything is ok.

PS: Indeed, we need unit tests ASAP.