Unable to use template strings

[jaydson]

Unfortunately, we can't use template strings due to jscs issues. We have a lot of code concatenation and we can improve the code by using template strings.

What can we do? Disable jscs?

Suggestions are welcome.

//cc @leobalter @UltCombo

[UltCombo]

What do you mean? Does JSCS crash or just emit an warning? If it is just an warning (as reported in this issue) then we can most likely suppress the warning with JSCS comments.

[jaydson]

Yep, it is just a warning message, but the message doesn't make any sense in the context. So, you mean we can disable JSCS entirely per block?

Example:

/* jscs ignore:start */
let bar = 'bar';
let foo = `foo ${bar}`;
/* jscs ignore:end */

PS: I don't know if this ignore is valid

[UltCombo]

I'd suggest more like

• https://github.com/es6rocks/harmonic/blob/fe57b82680a1757ee046f8615d6b7a1b60b948ac/src/bin/helpers.js#L38
• https://github.com/es6rocks/harmonic/blob/fe57b82680a1757ee046f8615d6b7a1b60b948ac/src/bin/client/harmonic-client.js#L4

[UltCombo]

Though, if we are going to use a lot of template strings, there would be too much comment litter.

[leobalter]

Nothing else to say after @UltCombo but how I liked the issue reference above the ignore lines. That's awesome to keep a minimum track for external projects bugs in the code.

[jaydson]

Solved by #109

[UltCombo]

Nice! :+1: