search

JSTOR-Labs / juncture

A framework for creating and displaying visual essays
https://juncture-digital.org
MIT License
52 stars 92 forks source link

401s from headRef function in index.html #56

Open jarmoza opened 1 year ago

jarmoza commented 1 year ago

@mdlincoln @nkelber

We're having trouble loading the Github pages homepage for the Print and Probability project: bookhistory.rocks

We're experiencing a series of 401s from the headRef function that seem to have something to do with the ghUnscopedToken value.

Screen Shot 2023-09-12 at 5 02 07 PM

Did someone change the access token for JSTOR-Labs/juncture recently?

nkelber commented 1 year ago

@rsnyder

rsnyder commented 1 year ago

The index.html file in the juncturerepo has been updated with a fix for the revoked GH token. Try updating/replacing the index.html file in your repo with this updated version. - https://github.com/JSTOR-Labs/juncture/blob/main/index.html

Please post an update in this issue if the problem persists after replacing the file.

jarmoza commented 1 year ago

Thanks @rsnyder. Looks like we're almost there. Any idea why we're now receiving this function getDomPath not found error coming out of (I believe) the Visual Essay vue component?

Screen Shot 2023-09-15 at 11 42 30 AM
rsnyder commented 1 year ago

It looks like there is an incompatibility with the updated index.html file and the VisualEssay component. If you forked the Juncture repo for your project re-syncing your fork with the upstream repo should fix it.

jarmoza commented 1 year ago

I don't think that's specifically what's causing the issue. There is no difference between our VisualEsssay.vue and the current one in juncture – as far as I can tell.

I'd just sync our fork with upstream as you suggest but GitHub is saying I'd have to discard over 800 commits to do so.

As the error indicates, getDompath as defined in index.html is not able to be found when it is called in the paramsInScope method in VisualEssay.vue.

jarmoza commented 1 year ago

Scratch that, Ron. I was looking at the version of VisualEssay.vue from our branch. Will post another update after I investigate/test.

jarmoza commented 1 year ago

@rsnyder Okay. I've manually synced up our files with the latest from juncture. We're almost there in having the website fully back up, but there is still some error happening. When our site comes up the right column where we'd expect an image is now blank. There are two remaining errors being reported in the console.

Screen Shot 2023-09-19 at 2 48 26 PM

rsnyder commented 1 year ago

OK, it looks like there was a small incompatibility remaining with the Image viewer component. Updating to the latest version of this should resolve the problem - https://github.com/JSTOR-Labs/juncture/blob/main/components/Image.vue