search

JSainsburyPLC / react-timelines

React Timelines Library
https://jsainsburyplc.github.io/react-timelines/
MIT License
257 stars 120 forks source link

Re send `clickElement` for sub-tracks #100

Closed cherta closed 5 years ago

cherta commented 5 years ago

When sub tracks are rendered clickElement is not passed along causing them to lose the ability to be notified when somebody clicks the element.

willbamford commented 5 years ago

@atkinchris any chance you could take a look at this?

atkinchris commented 5 years ago

Thanks for raising this @cherta. Could you add a test around this functionality, please?

atkinchris commented 5 years ago

I've added this in now, with a supporting test. All works happily with the demo's alert.

https://github.com/JSainsburyPLC/react-timelines/releases/tag/v2.6.1

cherta commented 5 years ago

Sorry @atkinchris I didn't saw your message til today. Thanks for adding the test.

atkinchris commented 5 years ago

Hi @cherta - it's OK, I added some tests and this is now included in the released version 2.6.1.