Querying HDD files for images/timestamps may be slowing screen rendering

JSearUK / Playthroughs

The aim is to create the system in such a way that it can be safely dropped into any other project

The Unlicense

0 stars 0 forks source link

Querying HDD files for images/timestamps may be slowing screen rendering #51

Open JSearUK opened 2 years ago

JSearUK commented 2 years ago

It's fine for a a few files, but I'm betting two HDD lookups per slot in 100 slots eats more time than I'd like.

Solution(?):

Get all the data ahead of time, in the .GetSlots() method of the Playthrough object

Note: This object needs to not be pickled for rollback; the .GetSlots() method needs a way to be told to get fast info or not, and it might be advisable for a progress bar to pop up if the process takes longer than 1-2 seconds

JSearUK commented 2 years ago

This appears to be heavily mitigated by f92985644ddc0ff876589e7d334f0abb26a68d09, which swaps two viewports out for vpgrids. Rather than waiting for all children to be processed, the vpgrid will show once the onscreen children are done, and then quietly load the rest in while the user is waving the mouse about.

This issue remains open, but has significantly dropped in priority.

JSearUK commented 2 years ago

There is some delay in handling text input which becomes more noticeable when the currently selected Playthrough has 100+ saves in it. This may be related to HDD activity - or it may not.

JSearUK commented 2 years ago

I'd quite like to know how to entirely suspend processing on screens/layers that are not the currently active modal one. I believe screens like Confirm("", yes=, no=) do this, which is why their return can be acted upon even within the same action list. It should also completely resolve the input delays experienced by players that have high numbers of Playthroughs/Slots showing on the main screen.

JSearUK commented 2 years ago

Timestamps are now pulled from the Playthrough object, instead of the disk.
Thumbnails are still read from the disk, but we've halved the number of seeks, at least. And it's possible that on-demand thumbnails are preferable to one monster loading delay, anyway.