search

JSearUK / Playthroughs

The aim is to create the system in such a way that it can be safely dropped into any other project
The Unlicense
0 stars 0 forks source link

Renaming doesn't store after interation #6

Closed KiloOscarSix closed 2 years ago

KiloOscarSix commented 3 years ago

Renaming is currently done based on json stored _save_name key. However, this doesn't directly edit the saved data so after an interaction the json data resets to default values

JSearUK commented 3 years ago

Browsing the files API suggested to me that there was no support for editing files, which was why I elected to wedge it all into the filename. However, I do like the notion of having all the data tucked away nice and safe inside the file, for a number of reasons. Caveat: I definitely don't want any changes made to Ren'Py's internals, no matter how tempting or easy the 'fix' would be, because it'd probably break something or get reverted later on.

KiloOscarSix commented 3 years ago

Aye, all our modifications should be done from an extension to renpy and not an edit

JSearUK commented 3 years ago

Referencing Issue #29