search

JSkimming / AspNet.Identity.EntityFramework.Multitenant

Multi-tenant support for ASP.NET Identity using Entity Framework
Apache License 2.0
132 stars 61 forks source link

Please add support for MVC 6 projects #15

Open weitzhandler opened 9 years ago

weitzhandler commented 9 years ago

Hi,

I tried adding the NuGet package (1.2.1) to my ASP.NET 5 MVC 6 (vNext) project, but looks like the project is doesn't support DNX.

Please update the projects frameworks.

Thanks

JSkimming commented 9 years ago

@weitzhandler I'm not familiar with how to target multiple frameworks in a class library, certainly not DNX. Do you know how?

If you submit a PR the build system, AppVeyor, will pick it up and build it. AppVeyor also provides a NuGet feed, so your PR can be included within you own project by referencing he build NuGet feed. See the readme for more details.

weitzhandler commented 9 years ago

@JSkimming I really don't know how to upgrade this, and anyway, MVC, is CTP stage, so it's alpha-beta version anyway.

And BTW, should we change the namespace to Microsoft.AspNet.Identity.EntityFramework.MultiTenancy, as in my code?

Here are the classes that match the ASP.NET MVC 6 class library. https://gist.github.com/weitzhandler/f9ebca6936ed0489d42d

JSkimming commented 9 years ago

@weitzhandler I'll have a look to see how to create multi targeted NuGet class libraries, it's the future so worth checking out.

Regarding namespaces, I dropped the Microsoft off the front, because this is not a Microsoft Library. And Multitenant vs MultiTenancy, well, does it make a difference? This is one of the two hardest things in computer science :smile:

To be honest, the merits of namespace changes are mostly moot, changing them would introduce a breaking change, that would mandate code changes on existing clients. Unless there's a hugely compelling reason to do so, I'm reluctant to change namespaces.

weitzhandler commented 9 years ago

Multitenant is actually a fair choice.

The reason I'd like to see the Microsoft prefix although this is not a MS product, is because I strongly believe this project should become part of the .NET foundation.

JSkimming commented 9 years ago

I know what you mean, I also feel this would be better supported in the Identity framework.

One benefit, of dropping the Microsoft off the front off this library, would mean the two libraries could work side-by-side to aid migration.

Microsoft often do this, they often try out a new library that's in a Microsoft.XXX namespace, then if they choose to move it to the core, they change it to System.XXX,

weitzhandler commented 9 years ago

@JSkimming That's not the case with the DNX and Core libraries. They will remain under Microsoft permanently. See this: https://github.com/aspnet/EntityFramework/issues/2665#issuecomment-124568413.