JSn1nj4 / ElliotDerhay.com

My personal website project.
MIT License
0 stars 1 forks source link

Fake token needs generating in memory for `TwitterServiceTest` #48

Closed JSn1nj4 closed 1 year ago

JSn1nj4 commented 2 years ago

In simplifying parts of App\Services\Twitter\TwitterService, it seems I inadvertently broke a few tests. These tests now directly depend on there being a token already. I've temporarily copied some code into multiple test cases to fix them, but this isn't a good permanent solution.

Maybe this can be solved with helper functions for 2 specific scenarios:

The following test cases currently depend on there being a token saved in DB storage:

JSn1nj4 commented 1 year ago

This class needs refactoring. These issues will immediately become easier if the token can be injected.

JSn1nj4 commented 1 year ago

Fixed by 6b0eb7f.