search

JStehouwer / FFD_CVPR2020

111 stars 22 forks source link

Problems about vgg_map_pca.py and train_vgg_map_pca.py #5

Open xiebinghua opened 4 years ago

xiebinghua commented 4 years ago

in vgg_map_pca.py, what does feats mean? I can not find the definition of feats. self.proj = torch.rand(feats.shape[1], 1) self.feat_mean = torch.rand(1, feats.shape[1]) and in function do_pca(), I can not find the definition of proj_in and feat_mean_in. proj = proj_in feat_mean = feat_mean_in in train_vgg_map_pca.py , "from network.vgg_pca_new import vgg16", where is network.vgg_pca_new? I suggest that you should check this part and fix these problems, good luck.

EricGzq commented 4 years ago

I also tried to run this code, and there are too many errors to be solved. And there are many 'train' scripts here, it is best to have a tutuorial to tell how to run them.

JStehouwer commented 4 years ago

Hi xiebinghua and EricGzq.

Thanks for you interest in our work! I'm sorry for the state of the code.

I agree that the code isn't clean, the COVID-19 situation really got in the way of releasing the source code, so I have been unable to go back and fix any problems (I'm working full time elsewhere now) in the code.

I really would like to get this all cleaned up and released, but I'm currently without a GPU machine in order to test the train/test process, which makes things even more difficult.

I will post back here when I'm finally able to fix things up.

RonDen commented 3 years ago

in vgg_map_pca.py, what does feats mean? I can not find the definition of feats. self.proj = torch.rand(feats.shape[1], 1) self.feat_mean = torch.rand(1, feats.shape[1]) and in function do_pca(), I can not find the definition of proj_in and feat_mean_in. proj = proj_in feat_mean = feat_mean_in in train_vgg_map_pca.py , "from network.vgg_pca_new import vgg16", where is network.vgg_pca_new? I suggest that you should check this part and fix these problems, good luck.

These files you mentioned is not availiable in the repo. What happened? And I find that the vgg.py file is empty, is there any mistake?

JStehouwer commented 3 years ago

I re-implemented the entire repository because the first version was difficult to use and understand. Hence those files may be found under the v1.0 Release, but are not found in the latest release. I hope that the latest release is much easier to use and understand.

I did not take the time to re-implement the vgg.py file, but this could be done simply by getting a PyTorch implementation of VGG and using the attention mechanism from xception.py.

If you need anything else, please let me know.