search

JSteunou / webstomp-client

Stomp client over websocket for browsers
Apache License 2.0
299 stars 59 forks source link

Publish build artifacts directly on github #10

Closed DzmitryShylovich closed 8 years ago

DzmitryShylovich commented 8 years ago

It would be nice if you publish latest stable artifacts directly in this repo so files can be served by https://rawgit.com/

Here is an example of such setup https://github.com/sockjs/sockjs-client/blob/master/dist/sockjs-0.3.4.js

JSteunou commented 8 years ago

Not a big fan of versioning build files for the same reason I dont put binaries, event if in the JS case it is plain text. What's the point of using rawgit.com over npm ?

DzmitryShylovich commented 8 years ago

I need to check if this library still compatible with my backend as it was with original stompjs. I want the simplest possible setup - add script tag with reference to cdn, without npm, installations etc. It's just for convenience.

I also don't like versioning here. Common practice is to include the latest stable file without version for example https://github.com/twbs/bootstrap/blob/master/dist/js/bootstrap.js

JSteunou commented 8 years ago

by versioning I mean using git for those file, not especially the suffix of the file.

DzmitryShylovich commented 8 years ago

Ok, so I think we can close this.