search

JSteunou / webstomp-client

Stomp client over websocket for browsers
Apache License 2.0
299 stars 59 forks source link

adding test suite #11

Closed yeyu456 closed 8 years ago

yeyu456 commented 8 years ago

Except the test files, adding some dev dependencies package for testing. Using mocha, chai, karma with some plugins as test framework. And using the gulp for tasks like creating a mock server and the code coverage. Libraries like core-js, sockjs and sockjs-client are make sure the browser compatibility test pass.

JSteunou commented 8 years ago

Wonderful ! Until I review it, could you format your code to respect the actual format ? Mostly indent (4 spaces) and end of file.

yeyu456 commented 8 years ago

Ok, no problem.Sorry for the format.Maybe the ide setting problem.

yeyu456 commented 8 years ago

@JSteunou As for the format, should we need to switch jscs to eslint since they're merged?

JSteunou commented 8 years ago

Yep, I would like to to replace jshint + jscs by eslint

yeyu456 commented 8 years ago

I can do that by the way if you don't mind.

JSteunou commented 8 years ago

Would be great! On another PR though.

yeyu456 commented 8 years ago

Barely use github for me, I think i have make a big mistake using the master repo for PR.Now i cannot do other PR since every new branch will add all of these commits. @JSteunou I will close this PR and redo it with a new fork and branch.

JSteunou commented 8 years ago

Ok. Did not see you where PRing from master. Best practice is too create a branch on your fork and PR from that branch so you can do multiple PR without being polluted.