Open yeyu456 opened 8 years ago
I hope I have time to review this soon, very low bandwith this week.
Haha, it's fine, take it easy :). And Happy Dragon Boat Festival today.
Happy festival to you 😊 Le 9 juin 2016 13:19, "yuye" notifications@github.com a écrit :
Haha, it's fine, take it easy :). And Happy Dragon Boat Festival today.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JSteunou/webstomp-client/pull/14#issuecomment-224866805, or mute the thread https://github.com/notifications/unsubscribe/ACNytygR0JbyTwagAuw11yd5XksRskrkks5qJ_a_gaJpZM4Ix08g .
I'm not a big fan of gulp, I replaced all grunt / gulp tasks with npm scripts inside my projects. Could you think of making several webpack.config and calling those in command line, making scripts for mock server, test runner, cleaning. Also files created for test purpose should be in a different folder than dist/
, I prefer leaving it untouched except for each new release. Maybe a folder inside test/
or a tmp/
folder.
Same for coverage, coveralls can be used in CLI, no need for gulp for that.
No problem.Your repo, your rule:smile:.I will update it.
Thank you @yeyu456 your help is really appreciated!
@JSteunou already finished.You can review now.remove all the gulp and use purely node script.
Except the test files, adding some dev dependencies package for testing. Using mocha, chai, karma with some plugins as test framework. And using the gulp for tasks like creating a mock server and the code coverage. Libraries like core-js, sockjs and sockjs-client are make sure the browser compatibility test pass.