search

JSteunou / webstomp-client

Stomp client over websocket for browsers
Apache License 2.0
299 stars 59 forks source link

Support binary data in "body" #68

Closed soal closed 6 years ago

soal commented 6 years ago

This is raw implementation for working with binary data in "body" block. If client and server work in binary mode, command and headers splits and converted in strings and and leave the body intact.

PR addresses problem described here #21

I think some review, testing and polish is needed, but it seems to work.

JSteunou commented 6 years ago

Could you make this PR cleaner / clearer without pushing the dist files?

soal commented 6 years ago

Since you have dist files in the repo, I can't just remove them from tree source, so I don't know how to do it. I think it needs another PR.

JSteunou commented 6 years ago

Sure this repo have dist files, but in any project, when making a PR, you must only push changed in source files so they can be picked and merged. Only the maintainer will build tag release publish etc.