JSubelj / g910-gkey-macro-support

GKey support for Logitech G910 Keyboard on Linux
GNU General Public License v3.0
99 stars 31 forks source link

Full new install/uninstall/README files... #40

Closed braoult closed 2 years ago

braoult commented 4 years ago

Looks ok now, for me. Easy to use. One command to install, one to uninstall. However, I still did not remove the (useless for me) create_config script, which should be done. I will just remove it in my fork, without pull req. Unfortunately, this could become a permanent fork.

suabo commented 2 years ago

I like the idea of having a uninstall script. Maybe you can fix the quality of your commit by removing not needed changes to readme (whitespaces and line breaks) so the check don't fails. Also I think there is too much changing at once. I would remove the selection of keyboard layout on install because it will need to get updated with every new layout like it is the case right now. Maybe make another pull request for that and try to read the current system layout to use in install on default?