search

JSv4 / Python-Redlines

Docx tracked change redlines for the Python ecosystem.
MIT License
28 stars 7 forks source link

Parametrise target #10

Closed ross-mcnairn-dev closed 6 days ago

ross-mcnairn-dev commented 1 month ago

In certain runtimes (AWS Lambda in my case), we are quite restricted on where we can write files. When we extract the compressed binaries and write them to the filesystem, they need to be written under /tmp in Lambda, as that's the only writeable filesystem.

So, here I'm parametrising the target path.

ross-mcnairn-dev commented 1 month ago

Sorrry I did something dumb - I opened up the original PR against main so now this is stacked on main w/ the changes from the other PR - I'll set this PR to draft for now. If the other ARM PR looks good then i'll update the base after merging it and then this will be ready for review.

JSv4 commented 3 weeks ago

@ross-mcnairn-dev, merged your ARM branch. Thanks for that and sorry for the delay.

ross-mcnairn-dev commented 3 weeks ago

@ross-mcnairn-dev, merged your ARM branch. Thanks for that and sorry for the delay.

Hey, no worries at all! Happy to be able to make a small contribution here :). I'll clean this one up and open it tonight.

ross-mcnairn-dev commented 3 weeks ago

OK, @JSv4 no rush on this, but this is ready for review when you've got a few this week

ross-mcnairn-dev commented 6 days ago

Hey @JSv4 , do you think you'd have time to review this this week?

JSv4 commented 6 days ago

Thanks for the reminder @ross-mcnairn-dev