RS028: Synchronized access to JSwingRipplesEIG node structure

[javierobledo]

Description: This means make this object a synchronized resource, only accessed when it is ready. In the original JRipples plugin, this is achieved using boolean fields like "locked" or "ready" to determinate if the resource is used, ready or other kind of states. Source: Team / Teacher Priority: Medium Stability: Negotiable Last Update: 2016-11-20 State: Not longer necessary Increment: 2 Type: Interation Associated user: End-User

Software Change Process:

• [X] Initialization
• [X] Concept Location
• [x] Impact Analysis
• [X] Prefactoring
• [X] Actualization
• [x] Postfactoring
• [x] Conclusion

[sgioia9]

You can use a mutex:

public class SomeClass {
private static final Object lock = new Object();

    xxx yyy someMethodWithACriticalSection() {
       ...
       synchronized(lock) {
           // crtitical section
           // access node structure here
        }
       ...
    }
}

[javierobledo]

no longer needed after #52

[javierobledo]

Initialization

Synchronized access to JSwingRipplesEIG node structure

[javierobledo]

Concept Location

Significant concepts: Synchronized, JSwingRipplesEIG, Node Concept Synchronized located in History, JSwingRipplesEIG Concept JSwingRipplesEIG is a class itself Concept Node located in JSwingRipplesEIG, JSwingRipplesNode

[javierobledo]

Impact Analysis

From JSwingRipplesEIG: History,JSwingRipplesEIGEdge, JSwingRipplesEIGEdgeEvent, JSwingRipplesEIGEvent, JSwingRipplesEIGListener, JSwingRipplesEIGNode, JSwingRipplesEIGNodeEvent, MemberHierarchySupportTest, NodeSearchBuilder, StartAnalysisDialog From JSwingRipplesEIGNode: JSwingRipplesEIG, JSwingRipplesEIGEdge, JSwingRipplesEIGNodeEvent, MemberHierarchySupportTest, AbstractMemberRenderer From History: UndoAction, JSwingRipplesEIG, HistoryTest

[javierobledo]

Prefactoring, Actualization, Postfactoring

No modification were made to the code

[javierobledo]

Conclusion

This problem was fixed by another method, which was declared in the issue #50, with the pull request #52