search

JTHall94 / Project2

0 stars 0 forks source link

Comments/Issues #1

Open JTHall94 opened 6 years ago

JTHall94 commented 6 years ago

Hey guys, thanks for checking out my project! Is there anything in the styling that needs to be fixed (especially things like alignment and whitespace)? Are there areas of my code that are redundant or need cleaning up? Any comments or suggestions are appreciated.

hstone102 commented 6 years ago

Great job with the color scheme on your page. The light background and the font color. The only thing that was a little hard to read were the headings hours, menu, and daily specials. Maybe make them bold? The font style is really nice however and goes well with the tone of the restaurant The picture you have has a lighter background which goes well with your light page background which is nice. I also like your tag line about the menu being a surprise. Great job overall!

JTHall94 commented 6 years ago

Holly,

Thanks for the comments! I was worried about the font-style of the headings not coming across clearly enough. I'll definitely try bolding the headings, and if that doesn't work I'll dive back into google fonts and find something that is similar in aesthetic but a little clearer.

Thanks for the stylistic complements! I spent way too much time thinking about what aesthetic to go for, and in the end scrapped most of what I had and went for a simpler, cleaner tone. I'm glad that came through!

Kiwipup commented 6 years ago

Hey Jacob I really like the elegant layout of your page, and it formats perfectly to a small screen! The no fuss design really allows you to focus on the content. The only things I noticed really is sort of just reaffirming what Holly said, my eyes are not really drawn to the headers or the name of the restaurant, maybe add something that will make them pop a little more! Also I noticed in your code that you have unused thead tags on your tables, I might be wrong but I don't believe your tables are required to have these if you don't have a use for them. Good job though it does look really good!

JTHall94 commented 6 years ago

Thanks Christina! I'll definitely look at the header issue; like I was saying to Holly, hopefully I'll be able to make it clearer with a simple solution such as bolding, but if I have to, I'll grab a new (but hopefully similar) font. Also, thanks for pointing out the unused tags! I made some changes to the style of the menu, and I think I left those in afterward. I will definitely fix that!