search

JTNDev / galaxy-integration-wii

MIT License
14 stars 1 forks source link

README doesn't match user_config.py #22

Open robross0606 opened 2 years ago

robross0606 commented 2 years ago

The README has the following lines:

If you have the game's ID in the filename you can enable match_by_id. Using only this option means that any file without ID falls back to exact match between filename and game name in GamesList.txt.

Enable best_match_game_detection to allow the best match algorithm. It can work as a fallback with match_by_id.

However, the user_config.py has no such option in it so it is a little vague how to "enable" these things. Do you add match_by_id with a value of "yes"? A value of True? Something else?

robross0606 commented 2 years ago

Also, I have enabled both of these but it completely mis-detects the ROM. The folder is named "R3ME01_Metroid Prime - Trilogy" and the wbf files inside are named "R3ME01". I have added both of the above settings to my user_config.py file but, for some reason, it detects the ROM as some Japanese game named "Rompers". "R3M" is the Metroid Prime Trilogy ID. "E01" is the European edition. https://www.gametdb.com/Wii/R3ME01

driscoll42 commented 2 years ago

It looks like the user_config.py has the code :

`#Enable to allow matching by ID, best_match_game_detection can be used as fallback match_by_id = True

Enable to allow the best match algorithm instead of exact game name

best_match_game_detection = True`

which looks like the option to me? Or am I missing something? I'm not the dev so I can't fix/change anything. Should be enabled by default. For the

For fun I tried the code out on "R3ME01_Metroid Prime - Trilogy" and even if match_by_id is False, it should still find it given that the fuzzy logic has it matching at the highest ratio.

robross0606 commented 2 years ago

Odd, I just re-downloaded the latest release and now the user_config.py file has it in there and no longer has match_by_id. One thing is certain. The user_config.py in the release.zip is not the same as the same file in the source.zip or repo. The release package appears to have an old or at least somewhat incomplete version. I'll use the version from the repo which is much more complete and try again.

driscoll42 commented 2 years ago

Hope it works, I still have some issues with this as in #19