Units.NET - Did not detect existing SourceLink config, also applied to console applications

angularsen commented 4 years ago

https://github.com/angularsen/UnitsNet/pull/811

Should probably not update console applications

CodeGen/CodeGen.csproj
UnitsNet.Benchmark/UnitsNet.Benchmark.csproj

Incorrectly fixed these (duplicate config)

UnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.csproj
UnitsNet/UnitsNet.csproj

It specifically didn't seem to recognize the existing <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />.

Correctly fixed these

UnitsNet.NumberExtensions/UnitsNet.NumberExtensions.csproj

angularsen commented 4 years ago

By the way, love your effort on this. Seems like a real good idea!

JTOne123 commented 4 years ago

thanks for detailed issue

JTOne123 / GitHubMassUpdater

Units.NET - Did not detect existing SourceLink config, also applied to console applications #8

Should probably not update console applications

Incorrectly fixed these (duplicate config)

Correctly fixed these